Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ts type imports #5733

Merged
merged 9 commits into from
May 22, 2020
Merged

fix: ts type imports #5733

merged 9 commits into from
May 22, 2020

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented May 21, 2020 •
edited
Loading

This commit fixes problem introduced in #5029 that TS type imports
(type Foo = import("./some/path/ts").SomeType) were ignored.

Fixes #5704

@bartlomieju bartlomieju added bug Something isn't working correctly cli related to cli/ dir labels May 22, 2020
@bartlomieju bartlomieju force-pushed the fix_ts_type_imports branch from 232078a to 2585f3d Compare May 22, 2020 10:56
@bartlomieju bartlomieju changed the title [WIP] fix: ts type imports fix: ts type imports May 22, 2020
@bartlomieju bartlomieju force-pushed the fix_ts_type_imports branch from 2585f3d to 641e541 Compare May 22, 2020 10:58
@bartlomieju bartlomieju requested a review from ry May 22, 2020 11:13
@bartlomieju bartlomieju mentioned this pull request May 22, 2020
Merged
ry
ry approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit e191c70 into denoland:master May 22, 2020
@bartlomieju bartlomieju deleted the fix_ts_type_imports branch May 22, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
bug Something isn't working correctly cli related to cli/ dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TS type imports broken in v1.0.1
2 participants
@bartlomieju @ry