Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Deno.dir and Diagnostics being present at stable runtime #5750

Merged
merged 2 commits into from
May 23, 2020
Merged

Fix Deno.dir and Diagnostics being present at stable runtime #5750

merged 2 commits into from
May 23, 2020

Conversation

lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented May 22, 2020 •
edited
Loading

Fix #5745 and Fix #5744

@lucacasonato lucacasonato changed the title Fix Deno.dir being present at stable runtime Fix Deno.dir and Diagnostics being present at stable runtime May 22, 2020
@bartlomieju bartlomieju added cli related to cli/ dir public API related to "Deno" namespace in JS labels May 22, 2020
ry
ry approved these changes May 23, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

#5503 is still on my queue - sorry for the delay

@ry ry merged commit 6feca0e into denoland:master May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
cli related to cli/ dir public API related to "Deno" namespace in JS
Projects
None yet
Milestone
No milestone
3 participants
@lucacasonato @ry @bartlomieju