Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): deserialize Permissions from JSON #5779

Merged
merged 5 commits into from
May 29, 2020
Merged

feat(cli): deserialize Permissions from JSON #5779

merged 5 commits into from
May 29, 2020

Conversation

akshatagarwl
Copy link
Contributor

This PR adds a way to deserialize Permissions from a JSON.

@akshatagarwl akshatagarwl changed the title deserialize Permissions from JSON feat(cli): deserialize Permissions from JSON May 23, 2020
@bartlomieju bartlomieju added cli related to cli/ dir feat new feature (which has been agreed to/accepted) labels May 23, 2020
@akshatagarwl akshatagarwl marked this pull request as ready for review May 23, 2020 10:35
@ry
Copy link
Member

ry commented May 23, 2020

I have nothing against this- but I don’t understand what it’s for?

@bartlomieju
Copy link
Member

bartlomieju commented May 23, 2020 •
edited
Loading

I have nothing against this- but I don’t understand what it’s for?

@ry needed for #4867, along with #5693. Probably should target to 1.1.0 branch This PR doesn't introduce user-facing feature so we can probably land on master

@ry
Copy link
Member

ry commented May 25, 2020

@bartlomieju Ok I will leave it to you to approve and land then.

@humancalico thanks for the patch!

@ry ry requested a review from bartlomieju May 29, 2020 06:42
bartlomieju
bartlomieju approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @humancalico

@bartlomieju bartlomieju merged commit ce246d8 into denoland:master May 29, 2020
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Jun 5, 2020
@akshatagarwl @bartlomieju
feat(cli): deserialize Permissions from JSON (denoland#5779)
b709d05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
cli related to cli/ dir feat new feature (which has been agreed to/accepted)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akshatagarwl @ry @bartlomieju