Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1228: Skip 3 fetch tests on windows #5803

Merged
merged 7 commits into from
May 24, 2020
Merged

Issue 1228: Skip 3 fetch tests on windows #5803

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a5b147d
Issue 1228: Skip 3 fetch tests on windows
mitch292 May 23, 2020
2b0f3e7
Issue 1228: Fix formatting on fetch_test.ts
mitch292 May 23, 2020
fa93ae4
bump
ry May 24, 2020
86dcdfd
bump2
ry May 24, 2020
42de8ad
bump3
ry May 24, 2020
bf8161a
try removing windows restrictions
ry May 24, 2020
736b009
bump4
ry May 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions cli/tests/unit/fetch_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,8 +367,6 @@ function bufferServer(addr: string): Deno.Buffer {

unitTest(
{
// FIXME(bartlomieju)
ignore: true,
perms: { net: true },
},
async function fetchRequest(): Promise<void> {
Expand All @@ -381,6 +379,7 @@ unitTest(
["Foo", "Bar"],
],
});
await response.arrayBuffer();
assertEquals(response.status, 404);
assertEquals(response.headers.get("Content-Length"), "2");

Expand All @@ -389,6 +388,9 @@ unitTest(
"POST /blah HTTP/1.1\r\n",
"hello: World\r\n",
"foo: Bar\r\n",
"accept: */*\r\n",
`user-agent: Deno/${Deno.version.deno}\r\n`,
"accept-encoding: gzip, br\r\n",
`host: ${addr}\r\n\r\n`,
].join("");
assertEquals(actual, expected);
Expand All @@ -397,8 +399,6 @@ unitTest(

unitTest(
{
// FIXME(bartlomieju)
ignore: true,
perms: { net: true },
},
async function fetchPostBodyString(): Promise<void> {
Expand All @@ -413,6 +413,7 @@ unitTest(
],
body,
});
await response.arrayBuffer();
assertEquals(response.status, 404);
assertEquals(response.headers.get("Content-Length"), "2");

Expand All @@ -421,6 +422,10 @@ unitTest(
"POST /blah HTTP/1.1\r\n",
"hello: World\r\n",
"foo: Bar\r\n",
"content-type: text/plain;charset=UTF-8\r\n",
"accept: */*\r\n",
`user-agent: Deno/${Deno.version.deno}\r\n`,
"accept-encoding: gzip, br\r\n",
`host: ${addr}\r\n`,
`content-length: ${body.length}\r\n\r\n`,
body,
Expand All @@ -431,8 +436,6 @@ unitTest(

unitTest(
{
// FIXME(bartlomieju)
ignore: true,
perms: { net: true },
},
async function fetchPostBodyTypedArray(): Promise<void> {
Expand All @@ -448,6 +451,7 @@ unitTest(
],
body,
});
await response.arrayBuffer();
assertEquals(response.status, 404);
assertEquals(response.headers.get("Content-Length"), "2");

Expand All @@ -456,6 +460,9 @@ unitTest(
"POST /blah HTTP/1.1\r\n",
"hello: World\r\n",
"foo: Bar\r\n",
"accept: */*\r\n",
`user-agent: Deno/${Deno.version.deno}\r\n`,
"accept-encoding: gzip, br\r\n",
`host: ${addr}\r\n`,
`content-length: ${body.byteLength}\r\n\r\n`,
bodyStr,
Expand Down