Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Improve Body's bufferFromStream #5826

Merged
merged 1 commit into from
May 25, 2020
Merged

refactor: Improve Body's bufferFromStream #5826

merged 1 commit into from
May 25, 2020

Conversation

marcosc90
Copy link
Contributor

Replace the recursive function with while loop and make the rejection be an Error instead of string.

@marcosc90 marcosc90 changed the title Improve Body's bufferFromStream refactor: Improve Body's bufferFromStream May 25, 2020
ry
ry approved these changes May 25, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@ry ry merged commit c9f0e34 into denoland:master May 25, 2020
@marcosc90 marcosc90 deleted the clean-bufer-from-stream branch May 25, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcosc90 @ry