Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(std/log): use writeAllSync instead of writeSync #5868

Merged
merged 1 commit into from
May 26, 2020
Merged

fix(std/log): use writeAllSync instead of writeSync #5868

merged 1 commit into from
May 26, 2020

Conversation

fuxingZhang
Copy link
Contributor

Deno.writeSync:
Returns the number of bytes written.
It is not guaranteed that the full buffer will be written in a single call.

@fuxingZhang
fix(std/log): use writeAllSync instead of writeSync
b5357c9 
Deno.writeSync:
Returns the number of bytes written. 
It is not guaranteed that the full buffer will be written in a single call.
@bartlomieju
Copy link
Member

@fuxingZhang thanks, can you add a test case demonstrating this problem? Using message longer than 20kB should surface the problem.

@bartlomieju bartlomieju added bug Something isn't working correctly std labels May 26, 2020
@cknight
Copy link
Contributor

cknight commented May 26, 2020

FYI, #5800 replaces Deno.writeSync() with a BufWriterSync.writeSync(). If #5800 goes ahead, this change is likely not needed.

ry
ry approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks good catch

@ry ry merged commit 24c36fd into denoland:master May 26, 2020
@fuxingZhang fuxingZhang deleted the patch-2 branch May 26, 2020 14:00
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@fuxingZhang
fix(std/log): use writeAllSync instead of writeSync (denoland/deno#5868)
baca8bf 
Deno.writeSync:
Returns the number of bytes written. 
It is not guaranteed that the full buffer will be written in a single call.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@fuxingZhang
fix(log): use writeAllSync instead of writeSync (denoland/deno#5868)
1d72a08 
Deno.writeSync:
Returns the number of bytes written. 
It is not guaranteed that the full buffer will be written in a single call.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@fuxingZhang @caspervonb
fix(log): use writeAllSync instead of writeSync (denoland/deno#5868)
40a9d01 
Deno.writeSync:
Returns the number of bytes written. 
It is not guaranteed that the full buffer will be written in a single call.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@fuxingZhang @caspervonb
fix(log): use writeAllSync instead of writeSync (denoland/deno#5868)
da549d6 
Deno.writeSync:
Returns the number of bytes written. 
It is not guaranteed that the full buffer will be written in a single call.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@fuxingZhang @caspervonb
fix(log): use writeAllSync instead of writeSync (denoland/deno#5868)
21dbe3e 
Deno.writeSync:
Returns the number of bytes written. 
It is not guaranteed that the full buffer will be written in a single call.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@fuxingZhang @caspervonb
fix(log): use writeAllSync instead of writeSync (denoland/deno#5868)
7649576 
Deno.writeSync:
Returns the number of bytes written. 
It is not guaranteed that the full buffer will be written in a single call.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@fuxingZhang @caspervonb
fix(log): use writeAllSync instead of writeSync (denoland/deno#5868)
71959bd 
Deno.writeSync:
Returns the number of bytes written. 
It is not guaranteed that the full buffer will be written in a single call.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@fuxingZhang @denobot
fix(log): use writeAllSync instead of writeSync (denoland/deno#5868)
d90fb23 
Deno.writeSync:
Returns the number of bytes written. 
It is not guaranteed that the full buffer will be written in a single call.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@fuxingZhang @denobot
fix(log): use writeAllSync instead of writeSync (denoland/deno#5868)
f5a3167 
Deno.writeSync:
Returns the number of bytes written. 
It is not guaranteed that the full buffer will be written in a single call.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
bug Something isn't working correctly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fuxingZhang @bartlomieju @cknight @ry