Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ts-expect-error instead of ts-ignore. #5869

Merged
merged 2 commits into from
May 26, 2020
Merged

Use ts-expect-error instead of ts-ignore. #5869

merged 2 commits into from
May 26, 2020

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented May 26, 2020

TypeScript 3.9 introduced // @ts-expect-error which can be used instead of // @ts-ignore, where if there is no error to ignore, it will throw. Moving to this has identified about 15 instances where we were "ignoring" errors that didn't exist.

ry
ry approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 228f9c2 into denoland:master May 26, 2020
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@kitsonk
Use ts-expect-error instead of ts-ignore. (denoland/deno#5869)
baea9b2
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@kitsonk
Use ts-expect-error instead of ts-ignore. (denoland/deno#5869)
b402a71
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@kitsonk @caspervonb
Use ts-expect-error instead of ts-ignore. (denoland/deno#5869)
2a31ebc
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@kitsonk @caspervonb
Use ts-expect-error instead of ts-ignore. (denoland/deno#5869)
f278366
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@kitsonk @caspervonb
Use ts-expect-error instead of ts-ignore. (denoland/deno#5869)
973717f
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@kitsonk @caspervonb
Use ts-expect-error instead of ts-ignore. (denoland/deno#5869)
ff93ca5
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@kitsonk @caspervonb
Use ts-expect-error instead of ts-ignore. (denoland/deno#5869)
33a7c85
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@kitsonk @denobot
Use ts-expect-error instead of ts-ignore. (denoland/deno#5869)
db07e02
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@kitsonk @denobot
Use ts-expect-error instead of ts-ignore. (denoland/deno#5869)
96502a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kitsonk @ry