Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli/blob) name for DenoBlob #5879

Merged
merged 1 commit into from
May 29, 2020
Merged

fix(cli/blob) name for DenoBlob #5879

merged 1 commit into from
May 29, 2020

Conversation

pevers
Copy link
Contributor

@pevers pevers commented May 26, 2020

This should fix #5851

Executed as described in this comment: https://github.com/denoland/deno/pull/4736/files#r407832029

Until all cli code is converted to JS this should fix Blob being named DenoBlob.

const b = new Blob()
b.constructor.name
DenoBlob

@CLAassistant
Copy link

CLAassistant commented May 26, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pevers pevers force-pushed the fix-denoblob-name branch 3 times, most recently from f5844b4 to 53792b9 Compare May 26, 2020 18:55
@pevers pevers force-pushed the fix-denoblob-name branch from 53792b9 to 8b9a129 Compare May 26, 2020 18:58
@pevers pevers mentioned this pull request May 26, 2020
Closed
@pevers pevers changed the title Fix name for DenoBlob fix(cli/blob) name for DenoBlob May 27, 2020
@bartlomieju bartlomieju added cli related to cli/ dir web related to Web APIs labels May 28, 2020
ry
ry approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

@ry ry merged commit fe7d682 into denoland:master May 29, 2020
@pevers pevers deleted the fix-denoblob-name branch May 29, 2020 07:35
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Jun 5, 2020
@pevers @bartlomieju
fix DenoBlob name (denoland#5879)
1ac3fa4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
cli related to cli/ dir web related to Web APIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

blob.constructor.name should return Blob not DenoBlob
4 participants
@pevers @CLAassistant @ry @bartlomieju