Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wasm to std/http/file_server.ts media types #5896

Merged
merged 1 commit into from
May 27, 2020
Merged

Add wasm to std/http/file_server.ts media types #5896

merged 1 commit into from
May 27, 2020

Conversation

seidtgeist
Copy link
Contributor

Since browsers and deno support wasm, I think this is reasonable in std’s file_server.

Care if I change or remove the shebang? This one would need run and --allow-read to work.

@seidtgeist
Add wasm to media types
e384b99 
Since browsers and deno support wasm, I think this is reasonable in std’s file_server.

Also, want me to change the shebangs? This one would need `run` and `--allow-read`.
ry
ry approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ry ry merged commit 55d3600 into denoland:master May 27, 2020
@ry
Copy link
Member

ry commented May 27, 2020

Care if I change or remove the shebang? This one would need run and --allow-read to work.

For file_server.ts ? Yes please.

@seidtgeist seidtgeist deleted the patch-1 branch May 27, 2020 14:31
@seidtgeist seidtgeist mentioned this pull request May 27, 2020
Merged
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Jun 5, 2020
@seidtgeist @bartlomieju
Add wasm to media types (denoland#5896)
967d2a2
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@seidtgeist
Add wasm to media types (denoland/deno#5896)
0644c85
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@seidtgeist
Add wasm to media types (denoland/deno#5896)
9f194dd
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@seidtgeist @caspervonb
Add wasm to media types (denoland/deno#5896)
b66c13e
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@seidtgeist @caspervonb
Add wasm to media types (denoland/deno#5896)
bbc808d
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@seidtgeist @caspervonb
Add wasm to media types (denoland/deno#5896)
7aa851f
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@seidtgeist @caspervonb
Add wasm to media types (denoland/deno#5896)
3040e44
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@seidtgeist @caspervonb
Add wasm to media types (denoland/deno#5896)
aad685d
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@seidtgeist @denobot
Add wasm to media types (denoland/deno#5896)
0a3ed7f
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@seidtgeist @denobot
Add wasm to media types (denoland/deno#5896)
7fa1002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seidtgeist @ry