Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(std/testing): benching progress callback #5941

Merged
merged 14 commits into from
Jun 2, 2020

Conversation

littletof
Copy link
Contributor

@littletof littletof commented May 29, 2020

closes: #5942
Related: #5841

TODOs

  • Add callback
  • Add possibility to clear registered benches
  • Add tests
  • deep copy progress
  • Tidy up interfaces
  • ? Add progress state enum ?
  • ? rename runsCount to runs so it is consistent with BenchmarkDefinition
  • JS DOC Benching
  • Update README.md
  • Provide examples

@littletof littletof changed the title Feat: benching progress callback feat(std/testing): benching progress callback May 31, 2020
@bartlomieju bartlomieju added the std label Jun 1, 2020
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - sorry for the slow review - I'm glad the benchmark code is getting some love, thanks @littletof

@ry ry merged commit 1db98f1 into denoland:master Jun 2, 2020
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Jun 5, 2020
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add benching progress
3 participants