fix: compile TS dependencies of JS files #6000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcarss
reviewed
May 31, 2020
bartlomieju
force-pushed
the
fix_compile_ts_from_js
branch
from
eb01278 to
f312061
Compare
ry
reviewed
May 31, 2020
ry
reviewed
May 31, 2020
This was referenced Jun 1, 2020
Closed
ry
reviewed
Jun 1, 2020
| #[test] | ||
| fn test_needs_compilation() { | ||
| assert!(!needs_compilation(false, MediaType::JavaScript, vec![])); | ||
| assert!(needs_compilation(true, MediaType::JavaScript, vec![])); |
There was a problem hiding this comment.
Could you add one more example?
assert!(!needs_compilation(true, MediaType::JavaScript, TODO));I'm not sure what TODO should be...
bartlomieju
added a commit
to bartlomieju/deno
that referenced
this pull request
Jun 5, 2020
This commit fixes regression that caused TS dependencies not being compiled. Check was added that ensures TS compiler is run if any of dependencies in module graph is TS/TSX/JSX.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5982