Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused check-only feature #6035

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Remove unused check-only feature #6035

merged 1 commit into from
Jun 2, 2020

Conversation

ry
Copy link
Member

@ry ry commented Jun 1, 2020

No description provided.

@ry ry force-pushed the rm-check-only branch from 93567b7 to e83826d Compare June 1, 2020 22:58
@ry ry force-pushed the rm-check-only branch from e83826d to 51848be Compare June 1, 2020 23:00
@ry ry requested a review from piscisaureus June 2, 2020 02:44
piscisaureus
piscisaureus approved these changes Jun 2, 2020
View reviewed changes
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm genuinely unsure whether this is truly unused or not. Let's land it and revert if it makes development suck.

@ry
Copy link
Member Author

ry commented Jun 2, 2020

@piscisaureus it's not referenced elsewhere in the repo, so it's definitely unused

@ry ry merged commit b7b6e06 into denoland:master Jun 2, 2020
@ry ry deleted the rm-check-only branch June 2, 2020 18:56
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Jun 5, 2020
@ry @bartlomieju
Remove unused check-only feature (denoland#6035)
d9b8a12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ry @piscisaureus