Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing es_snapshot test #6111

Merged
merged 5 commits into from
Jun 5, 2020
Merged

Add failing es_snapshot test #6111

merged 5 commits into from
Jun 5, 2020

Conversation

ry
Copy link
Member

@ry ry commented Jun 4, 2020

ref denoland/rusty_v8#396
ref #5858

> cargo test -p deno_core es_snapshot -- --nocapture --test-threads=1
   Compiling deno_core v0.47.1 (/Users/rld/src/deno/core)
    Finished test [unoptimized + debuginfo] target(s) in 7.17s
     Running target/debug/deps/deno_core-503781d8e8ace9c3

running 1 test
test es_isolate::tests::es_snapshot ... hello
global handle not serialized: 0x1b410820d889: [SourceTextModule] in OldSpace
 - map: 0x1b4108040d85 <Map[72]>
 - exports: 0x1b410820f1e5 <HashTable[11]>
 - status: 5
 - exception: 0x1b4108040385 <the_hole>
 - origin: 0x1b410820f17d <String[15]: file:///main.js>
 - code: 0x1b410820f369 <JSGenerator>
 - requested_modules: 0x1b41080406e9 <FixedArray[0]>
 - script: 0x1b410820d70d <Script>
 - import_meta: 0x1b4108040385 <the_hole>



#
# Fatal error in ../../../../v8/src/api/api.cc, line 871
# Check failed: handle_checker.CheckGlobalAndEternalHandles().
#
#
#
#FailureMessage Object: 0x7ffee4835920
==== C stack trace ===============================

    0   deno_core-503781d8e8ace9c3          0x000000010c0a52a3 v8::base::debug::StackTrace::StackTrace() + 19
    1   deno_core-503781d8e8ace9c3          0x000000010ca6cf3b v8::platform::(anonymous namespace)::PrintStackTrace() + 59
    2   deno_core-503781d8e8ace9c3          0x000000010c09af51 V8_Fatal(char const*, int, char const*, ...) + 337
    3   deno_core-503781d8e8ace9c3          0x000000010b58cb00 v8::(anonymous namespace)::ConvertSerializedObjectsToFixedArray(v8::Local<v8::Context>) + 0
    4   deno_core-503781d8e8ace9c3          0x000000010b56e5fc rusty_v8::snapshot::SnapshotCreator::create_blob::hc3f54dbea66684fa + 44
    5   deno_core-503781d8e8ace9c3          0x000000010b477518 deno_core::core_isolate::CoreIsolate::snapshot::h7c0c6170541b8d2d + 552
    6   deno_core-503781d8e8ace9c3          0x000000010b48f52a deno_core::es_isolate::tests::es_snapshot::ha7fbef34601b9225 + 442
    7   deno_core-503781d8e8ace9c3          0x000000010b3ca5b1 _ZN9deno_core10es_isolate5tests11es_snapshot28_$u7b$$u7b$closure$u7d$$u7d$17h7db93b6746a21d7fE + 17
    8   deno_core-503781d8e8ace9c3          0x000000010b44b041 core::ops::function::FnOnce::call_once::h9dffaa6f830a7170 + 17
    9   deno_core-503781d8e8ace9c3          0x000000010b4e643e _ZN83_$LT$alloc..boxed..Box$LT$F$GT$$u20$as$u20$core..ops..function..FnOnce$LT$A$GT$$GT$9call_once17hbcb16cf7de1a02edE + 62
    10  deno_core-503781d8e8ace9c3          0x000000010cb0c62b __rust_maybe_catch_panic + 27
    11  deno_core-503781d8e8ace9c3          0x000000010b4ffb56 _ZN4test8run_test14run_test_inner28_$u7b$$u7b$closure$u7d$$u7d$17h6b70d070cbe0a930E + 886
    12  deno_core-503781d8e8ace9c3          0x000000010b4ff336 test::run_test::run_test_inner::h5225bdad4fdb9858 + 198
    13  deno_core-503781d8e8ace9c3          0x000000010b4fdab7 test::run_test::h800b5b6e42159ce4 + 583
    14  deno_core-503781d8e8ace9c3          0x000000010b4ec849 test::console::run_tests_console::ha053ff913fbf1fd7 + 4969
    15  deno_core-503781d8e8ace9c3          0x000000010b4fa02a test::test_main::h0fa6277010c5792d + 298
    16  deno_core-503781d8e8ace9c3          0x000000010b4fb42e test::test_main_static::h1484d167c868d607 + 286
    17  deno_core-503781d8e8ace9c3          0x000000010b3ce188 deno_core::main::hb03f08d585868835 + 24
    18  deno_core-503781d8e8ace9c3          0x000000010b4071be _ZN3std2rt10lang_start28_$u7b$$u7b$closure$u7d$$u7d$17h96ffb9a1dc8debd2E + 14
    19  deno_core-503781d8e8ace9c3          0x000000010cb05e68 std::panicking::try::do_call::h7c88c220bfff6b21 + 24
    20  deno_core-503781d8e8ace9c3          0x000000010cb0c62b __rust_maybe_catch_panic + 27
    21  deno_core-503781d8e8ace9c3          0x000000010cb0679a std::rt::lang_start_internal::h94930f81f540a165 + 602
    22  deno_core-503781d8e8ace9c3          0x000000010b4071a1 std::rt::lang_start::hed28d671141e2f7d + 65
    23  deno_core-503781d8e8ace9c3          0x000000010b3ce1b2 main + 34
    24  libdyld.dylib                       0x00007fff67b25cc9 start + 1
error: test failed, to rerun pass '-p deno_core --lib'

Caused by:
  process didn't exit successfully: `/Users/rld/src/deno/target/debug/deps/deno_core-503781d8e8ace9c3 es_snapshot --nocapture --test-threads=1` (signal: 4, SIGILL: illegal instruction)

@ry ry requested a review from piscisaureus June 5, 2020 12:53
@ry
Copy link
Member Author

ry commented Jun 5, 2020

@piscisaureus Thanks for the fix. I think we should land it.

@piscisaureus
Copy link
Member

LGTM but can you either remove or enable the commented out asserts?

@ry ry mentioned this pull request Jun 5, 2020
6 tasks
@piscisaureus
Copy link
Member

PS this can land

@ry ry merged commit 79d9cf5 into denoland:master Jun 5, 2020
@ry ry deleted the es_snapshot branch June 5, 2020 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants