fix: unexpected skip of emit in TS compiler and double compilation of dynamic imports

cli/js/compiler.ts

@@ -105,7 +105,7 @@ const DEFAULT_BUNDLER_OPTIONS: ts.CompilerOptions = {
 };
 
 const DEFAULT_COMPILE_OPTIONS: ts.CompilerOptions = {
-  allowJs: false,
+  allowJs: true,
   allowNonTsExtensions: true,
   checkJs: false,
   esModuleInterop: true,
@@ -1167,7 +1167,22 @@ function compile(request: CompilerRequestCompile): CompileResult {
         setRootExports(program, rootNames[0]);
       }
       const emitResult = program.emit();
-      assert(emitResult.emitSkipped === false, "Unexpected skip of the emit.");
+      // If `checkJs` is off we still might be compiling entry point JavaScript file
+      // (if it has `.ts` imports), but it won't be emitted. In that case we skip
+      // assertion.
+      if (!bundle) {
+        if (options.checkJs) {
+          assert(
+            emitResult.emitSkipped === false,
+            "Unexpected skip of the emit."
+          );
+        }
+      } else {
+        assert(
+          emitResult.emitSkipped === false,
+          "Unexpected skip of the emit."
+        );
+      }
       // emitResult.diagnostics is `readonly` in TS3.5+ and can't be assigned
       // without casting.
       diagnostics = emitResult.diagnostics;

cli/tests/integration_tests.rs

@@ -1869,6 +1869,7 @@ itest!(cjs_imports {
 itest!(ts_import_from_js {
   args: "run --quiet --reload ts_import_from_js.js",
   output: "ts_import_from_js.js.out",
+  http_server: true,
 });
 
 itest!(proto_exploit {

cli/tests/ts_import_from_js.deps.js

@@ -0,0 +1,2 @@
+import "./005_more_imports.ts";
+export { printHello } from "http://localhost:4545/cli/tests/subdir/mod2.ts";

cli/tests/ts_import_from_js.js

@@ -1 +1,3 @@
-import "./005_more_imports.ts";
+import { printHello } from "./ts_import_from_js.deps.js";
+printHello();
+console.log("success");

cli/tests/ts_import_from_js.js.out

@@ -1 +1,3 @@
 Hello
+Hello
+success