fix(std/datetime): uppercase hour symbols #7107

timreichen · 2020-08-18T23:34:02Z

Fix wrong symbol casing.
replace h and hh with H and HH respectively.
Lowercase is reserved for 12 hour days, uppercase for 24 hour days.

caspervonb · 2020-08-18T23:47:06Z

Lowercase is reserved for 12 hour days, uppercase for 24 hour days.

Based on what? in https://en.wikipedia.org/wiki/ISO_8601 hh is 24 hour format.

timreichen · 2020-08-19T00:07:12Z

Based on what? in https://en.wikipedia.org/wiki/ISO_8601 hh is 24 hour format.

Yes, but based on http://www.unicode.org/reports/tr35/tr35-dates.html#Date_Field_Symbol_Table, the upper/lowercase convention is widely adopted in many different languages like swift and java. The formatter doesn't use ISO8601 symbols, because the ISO symbols are very limiting (for example: formatter has a for PM an AM parsing which doesn't exist in ISO8601).

This allows deno to extend the formatter if needed without having breaking changes.

Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>

All benchmarks are done in Rust and can be invoked with `cargo bench`. Currently this has it's own "harness" that behaves like `./tools/benchmark.py` did. Because of this tests inside `cli/bench` are currently not run. This should be switched to the language provided harness once the `#[bench]` attribute has been stabilized.

Closes #7602

This removes the dependency on global state and instead relies on the runtime's internal state to get the script sources it saw when it collected code coverage for them.

…rs (#7553)

This commit adds support for stack traces in "deno_core". Implementation of "Display" trait for "JsError" has been updated and in consequence "deno_core::js_check" became obsolete and removed.

Fixes #7630

This encloses symbol keys when used in objects with brackets (e.g [Symbol("Symbol.iterator")]).

This quotes and escapes symbol descriptions that contains characters outside of the basic alpha-numeric identifier range.

…en/deno into fix-parser-symbol-names

timreichen · 2020-09-24T18:55:02Z

close on favor of #7661

timreichen changed the title ~~uppercase hour symbols~~ fix(std/datetime): uppercase hour symbols Aug 22, 2020

kitsonk and others added 27 commits August 24, 2020 19:43

feat: update to TypeScript 4.0 (#6514)

c4d5b01

docs(std/fs): provide more context on unstable perm (#6748)

54d336a

test(std/wasi): add wasi-testsuite as a submodule (#7042)

f717426

fix(std/wasi): return flags from fd_fdstat_get (#7112)

d0ccab7

refactor: remove OpError, use ErrBox everywhere (#7187)

9bfb0df

Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>

Remove some more unnecessary 'to_string()' calls (#7190)

aead9dc

Use https instead of ssh for wasi-test-suite submodule (#7202)

5634823

docs: add fetch and read/write examples (#7186)

7652353

Simplify ErrBox-to-class mapping & hook it up to core json ops (#7195)

c8b5f1e

fix(cli): revert "never type check deno info #6978" (#7199)

a7fd3a4

test(std/testing): reduce bench test iterations to 1e3 (#7200)

80111e5

upgrade: swc, deno_doc, deno_lint, dprint (#7194)

4a0bc74

test(url_test): disable no-self-assign rule here (#7204)

6d964fc

docs(build): details on updating rust (#7133)

7583fd0

fix(std/node): "events" and "util" modules (#7170)

e1564f3

feat(std/testing): add assertNotMatch (#6775)

6b95b25

docs(std/log): update example (#7157)

81811e8

test(std/datetime): port golang dayOfYear tests (#7105)

58bcb98

fix(std/wasi): ignore lint errors (#7197)

59428e3

test(std/wasi): seperate test runner into a module (#7191)

992248e

fix(std/wasi): invalid number to bigint conversion in fd_tell (#7215)

672350b

chore(std/encoding): disable no-control-regex (#7219)

beec3ae

fix(deno install): Strip "@..." suffixes from inferred names (#7223)

3d23208

refactor: migrate ops to new dispatch wrapper (#7118)

7e94685

fix benchmark publish (#7232)

2573d09

fix benchmark publish again (#7235)

935c928

caspervonb and others added 27 commits September 21, 2020 16:09

fix(cli/repl): interpret object literals as expressions (#7591)

9caeff3

docs: minor documentation improvement (#7603)

5a8a4da

Closes #7602

docs: V8 is a JavaScript engine, not a runtime (#7619)

43fa68e

refactor(cli/coverage): remove dependency on global state (#7616)

cca8856

This removes the dependency on global state and instead relies on the runtime's internal state to get the script sources it saw when it collected code coverage for them.

fix(logger): change log level to which prefix added (#7582)

c30c782

fix(cli/console): quote object symbol keys that are invalid identifie…

a33315a

…rs (#7553)

refactor(cli/fmt_errors): Color stack traces in Rust (#7628)

a43984c

fix: clearing timers race condition (#7617)

dd1cd4d

feat(std/node): implement getSystemErrorName() (#7624)

f601721

chore(std/hash): update crates (#7631)

cf0c491

refactor(core): support error stack, remove js_check (#7629)

68fd7a9

This commit adds support for stack traces in "deno_core". Implementation of "Display" trait for "JsError" has been updated and in consequence "deno_core::js_check" became obsolete and removed.

fix: ignore fileExists in tsc host (#7635)

751bb45

Fixes #7630

Actually remove js_check (#7636)

ffd08a2

feat: bump TypeScript to 4.0.3 (#7637)

49807ac

docs: ts upgrade instructions to exclude some .d.ts files (#7638)

8a6a390

fix(watch): watch importmap file for changes (#7580)

29dd62b

fix(cli/console): enclose symbol keys in brackets (#7642)

d68fb81

This encloses symbol keys when used in objects with brackets (e.g [Symbol("Symbol.iterator")]).

Add example for deno_core (#7611)

71c2497

mark shell code blocks as sh instead of bash (#7645)

1021dad

fix(std/fs): mark createWalkEntry(Sync) as internal (#7643)

3ac9f1e

fix(cli/console): quote non-alphanumeric symbols (#7641)

e1b61d6

This quotes and escapes symbol descriptions that contains characters outside of the basic alpha-numeric identifier range.

fix(cli/coverage): print lines with no coverage to stdout (#7640)

6254bd4

uppercase hour symbols

281a584

update readme

b5e755b

link to unicode LDML

f2339e4

update

5b697ea

Merge branch 'fix-parser-symbol-names' of https://github.com/timreich…

929dcb6

…en/deno into fix-parser-symbol-names

timreichen closed this Sep 24, 2020

timreichen deleted the fix-parser-symbol-names branch September 25, 2020 20:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(std/datetime): uppercase hour symbols #7107

fix(std/datetime): uppercase hour symbols #7107

timreichen commented Aug 18, 2020

caspervonb commented Aug 18, 2020 •

edited

Loading

timreichen commented Aug 19, 2020 •

edited

Loading

timreichen commented Sep 24, 2020

fix(std/datetime): uppercase hour symbols #7107

fix(std/datetime): uppercase hour symbols #7107

Conversation

timreichen commented Aug 18, 2020

caspervonb commented Aug 18, 2020 • edited Loading

timreichen commented Aug 19, 2020 • edited Loading

timreichen commented Sep 24, 2020

caspervonb commented Aug 18, 2020 •

edited

Loading

timreichen commented Aug 19, 2020 •

edited

Loading