Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: multi line deno_lint diagnostics #7303

Merged
merged 5 commits into from
Sep 2, 2020
Merged

chore: multi line deno_lint diagnostics #7303

merged 5 commits into from
Sep 2, 2020

Conversation

lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Sep 1, 2020 •
edited
Loading

TODO

  • release new deno_lint and update it here

In the future we should combine this diagnostic formatter with the one in cli/fmt_error.rs.

@lucacasonato lucacasonato added the cli related to cli/ dir label Sep 1, 2020
@lucacasonato lucacasonato marked this pull request as ready for review September 1, 2020 14:01
bartlomieju
bartlomieju approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucacasonato lucacasonato merged commit fe47da9 into denoland:master Sep 2, 2020
@lucacasonato lucacasonato deleted the multi_line_diagnostics2 branch September 2, 2020 09:39
@lucacasonato lucacasonato mentioned this pull request Sep 2, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
cli related to cli/ dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucacasonato @bartlomieju