Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): add tsc2 #7942

Merged
merged 4 commits into from
Oct 13, 2020
Merged

refactor(cli): add tsc2 #7942

merged 4 commits into from
Oct 13, 2020

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Oct 12, 2020

This is the last of the "new" infrastructure that will unblock being able to move everything over.

I will do a subsequent PR based on this to actually move something else over the requires the TS compiler.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - please proceed to land tsc2.rs when you think it's ready.

I look forward to tsc.rs and module_graph.rs being removed in the near future.

@kitsonk kitsonk changed the title [WIP] add tsc2 refactor(cli): add tsc2 Oct 13, 2020
@kitsonk kitsonk marked this pull request as ready for review October 13, 2020 04:52
cli/module_graph2.rs Show resolved Hide resolved
cli/module_graph2.rs Show resolved Hide resolved
cli/tsc/99_main_compiler.js Show resolved Hide resolved
cli/tsc/99_main_compiler.js Outdated Show resolved Hide resolved
cli/tsc/99_main_compiler.js Show resolved Hide resolved
cli/tsc2.rs Outdated Show resolved Hide resolved
@bartlomieju
Copy link
Member

@kitsonk looks great! Just a few minor nitpicks/questions, looking forward to landing it!

@kitsonk kitsonk merged commit 10654fa into denoland:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants