Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(cli): ensure modules can export typed JS files #8101

Merged
merged 1 commit into from
Oct 24, 2020
Merged

test(cli): ensure modules can export typed JS files #8101

merged 1 commit into from
Oct 24, 2020

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Oct 24, 2020

Adds a test which verifies that #5935 is fixed.

bartlomieju
bartlomieju approved these changes Oct 24, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitsonk kitsonk merged commit dd95281 into denoland:master Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kitsonk @bartlomieju