Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(op_crates/fetch): redirect: "manual" fetch should return type: "default" response #8353

Merged
merged 2 commits into from
Nov 24, 2020
Merged

fix(op_crates/fetch): redirect: "manual" fetch should return type: "default" response #8353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8cc10d
fix(op_crates/web): redirect: "manual" should return type: "default"…
lucacasonato Nov 11, 2020
97211ec
fix test
lucacasonato Nov 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions cli/tests/unit/fetch_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,18 +693,10 @@ unitTest(
const response = await fetch("http://localhost:4546/", {
redirect: "manual",
}); // will redirect to http://localhost:4545/
assertEquals(response.status, 0);
assertEquals(response.statusText, "");
assertEquals(response.url, "");
assertEquals(response.type, "opaqueredirect");
try {
await response.text();
fail(
"Reponse.text() didn't throw on a filtered response without a body (type opaqueredirect)",
);
} catch (e) {
return;
}
assertEquals(response.status, 301);
assertEquals(response.url, "http://localhost:4546/");
assertEquals(response.type, "default");
assertEquals(response.headers.get("Location"), "http://localhost:4545/");
},
);

Expand Down
12 changes: 4 additions & 8 deletions op_crates/fetch/26_fetch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1342,15 +1342,11 @@
});
return new Response(null, responseInit);
case "manual":
responseInit = {};
responseData.set(responseInit, {
type: "opaqueredirect",
redirected: false,
url: "",
});
return new Response(null, responseInit);
// On the web this would return a `opaqueredirect` response, but
// those don't make sense server side. See denoland/deno#8351.
return response;
case "follow":
// fallthrough
// fallthrough
default: {
let redirectUrl = response.headers.get("Location");
if (redirectUrl == null) {
Expand Down