Add copyFile/copyFileSync (and remove unused fbs table WriteFileSync)
#863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinkassimo
changed the title
copyFile/copyFileSync (and remove unused fbs table WriteFileSync)
|
Thanks io.Copy is not this function in Go. It doesn't exist in Go. I'm slightly concerned about adding it because of that fact. |
ry
approved these changes
Sep 30, 2018
src/msg.fbs
Outdated
| perm: uint; | ||
| // perm specified by https://godoc.org/os#FileMode | ||
| } | ||
|
|
There was a problem hiding this comment.
Good catch - thanks - can you remove this in a standalone commit?
ry
added a commit
to ry/deno
that referenced
this pull request
Oct 4, 2018
- Improve fetch headers (denoland#853) - Add deno.truncate (denoland#805) - Add copyFile/copyFileSync (denoland#863) - Limit depth of output in console.log for nested objects, and add console.dir (denoland#826) - Guess extensions on extension not provided (denoland#859) - Renames: deno.platform -> deno.platform.os deno.arch -> deno.platform.arch - Upgrade TS to 3.0.3 - Add readDirSync(), readDir() - Add support for TCP servers and clients. (denoland#884) Adds deno.listen(), deno.dial(), deno.Listener and deno.Conn.
Merged
ry
added a commit
that referenced
this pull request
Oct 4, 2018
- Improve fetch headers (#853) - Add deno.truncate (#805) - Add copyFile/copyFileSync (#863) - Limit depth of output in console.log for nested objects, and add console.dir (#826) - Guess extensions on extension not provided (#859) - Renames: deno.platform -> deno.platform.os deno.arch -> deno.platform.arch - Upgrade TS to 3.0.3 - Add readDirSync(), readDir() - Add support for TCP servers and clients. (#884) Adds deno.listen(), deno.dial(), deno.Listener and deno.Conn.
hardfist
pushed a commit
to hardfist/deno
that referenced
this pull request
Aug 7, 2024
Bumped versions for 0.302.0 Please ensure: - [x] Crate versions are bumped correctly To make edits to this PR: ```shell git fetch upstream release_0_302.0 && git checkout -b release_0_302.0 upstream/release_0_302.0 ``` cc @devsnek Co-authored-by: devsnek <devsnek@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is in this PR
deno.copyFile(from, to)anddeno.copyFileSync(from, to)WriteFileSyncImplementation reference
io.Copy(to, from)fs.copyFile(src, dest[, flags], callback)std::fs::copy(from: P, to: Q)FileUtils.copy_file(src, dest, preserve = false, dereference = true)Details
Implemented
copyFilesince it is a handy call.An alternative implementation could have been done by using
deno.File, open 2 files and docopybetween file descriptors, but would require multiple serialization/deserialization instead of once.Removed
table WriteFileSync { ... }frommsg.fbssince I could not found where it is used. It was introduced in #846, probably due to a rebase/merge error.