Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: align Encoding APIs to spec using WPT #9004

Merged
merged 5 commits into from
Jan 5, 2021
Merged

fix: align Encoding APIs to spec using WPT #9004

merged 5 commits into from
Jan 5, 2021

Conversation

lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Jan 5, 2021 •
edited
Loading

Part of #9001

bartlomieju
bartlomieju approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cli/tests/integration_tests.rs Show resolved Hide resolved
cli/tests/unit/text_encoding_test.ts Show resolved Hide resolved
op_crates/web/text_encoding_test.js Show resolved Hide resolved
@lucacasonato lucacasonato merged commit 0d41e21 into denoland:master Jan 5, 2021
@lucacasonato lucacasonato deleted the wpt-text-encoding branch January 5, 2021 18:50
@kt3k kt3k mentioned this pull request Jan 18, 2021
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucacasonato @bartlomieju