tests(wpt/console): Enables web platform tests for console #9013
+21
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tarikeshaq
commented
Jan 6, 2021
| // The console seems to be the only one that should be writable and non-enumerable | ||
| // thus we don't have a unique helper for it. If other properties follow the same | ||
| // structure, it might be worth it to define a helper in `util` | ||
| windowOrWorkerGlobalScope.console.enumerable = false; |
There was a problem hiding this comment.
Wasn't sure if this is the best place to do this, it seemed to me that non of the existing "util" functions do the desired behavior and since this seemed like a one-off I put it here, open to moving this
ghost
reviewed
Jan 6, 2021
tarikeshaq
force-pushed
the
test-wpt-console
branch
from
d1b2624 to
d14d003
Compare
28 tasks
andreubotella
pushed a commit
to andreubotella/deno
that referenced
this pull request
Sep 11, 2021
A comment in `runtime.js` reads that `console` seems to be "the only one that should be writable and non-enumerable", which explains why it is declared with `util.writable` to then have the property descriptor's `enumerable` key changed to false. That is not in fact true, and it wasn't even in denoland#9013, when that behavior was introduced. In fact all WebIDL interfaces are writable and non-enumerable, declared with `util.nonEnumerable` – the difference here being that `console` is a namespace / object. WebIDL, however, treats namespaces and interfaces similarly, and defines them with the same descriptor keys, so this PR changes the definition of `console` to use `util.nonEnumerable`.
andreubotella
pushed a commit
to andreubotella/deno
that referenced
this pull request
Sep 11, 2021
A comment in `runtime.js` reads that `console` seems to be "the only one that should be writable and non-enumerable", which explains why it is declared with `util.writable` but then has its property descriptor's `enumerable` key changed to false. But it is not in fact true that `console` is the only global property for which this holds, and it wasn't even when this behavior was introduced in denoland#9013. All WebIDL interfaces are also writable and non-enumerable – the only difference here being that `console` is a namespace rather than an interface. Since WebIDL interfaces are defined with `util.nonEnumerable`, and `console` uses the same descriptor keys, this PR changes the definition of `console` to use `util.nonEnumerable` as well.
bartlomieju
pushed a commit
that referenced
this pull request
Sep 11, 2021
A comment in `runtime.js` reads that `console` seems to be "the only one that should be writable and non-enumerable", which explains why it is declared with `util.writable` but then has its property descriptor's `enumerable` key changed to false. But it is not in fact true that `console` is the only global property for which this holds, and it wasn't even when this behavior was introduced in #9013. All WebIDL interfaces are also writable and non-enumerable – the only difference here being that `console` is a namespace rather than an interface. Since WebIDL interfaces are defined with `util.nonEnumerable`, and `console` uses the same descriptor keys, this PR changes the definition of `console` to use `util.nonEnumerable` as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A part of #9001
Notes:
.htmlfiles in the wpt console directory, I ignored those. They seem to be manual tests, anywho just thought I'd note it down.I putTODO(???)on the failing test suites, they seem to have trivial fixes (like theSymbol.toStringTag) but I opted to first get this PR up to see if it's better to file another issue for those (maybe agood first issue👀 ) or solve the trivial ones hereFixes were small enough so I'll add them in a commit here