fix(op_crates/crypto): Test crypto.getRandomValues() with wpt #9016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires #9015 to be merged first. |
bnoordhuis
approved these changes
Jan 7, 2021
yacinehmito
force-pushed
the
test-crypto-getrandomvalues
branch
from
976ac1e to
d1e9aad
Compare
yacinehmito
force-pushed
the
test-crypto-getrandomvalues
branch
from
d1e9aad to
d35c7be
Compare
|
@lucacasonato I think this is mergeable. |
24 tasks
yacinehmito
force-pushed
the
test-crypto-getrandomvalues
branch
from
d35c7be to
1be8cdc
Compare
|
Thanks @yacinehmito |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
crypto.getRandomValues()so that it passes the tests from web-platform-tests. The core logic doesn't really change: it just adds validation that is expected in the W3C recommandation.This follows #8990 and precedes #8984.