fix: align btoa with wpt tests #9053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
caspervonb
changed the title
|
Blocked on #9015 |
|
@caspervonb is this ready? |
Been waiting on the |
caspervonb
force-pushed
the
test-add-atob-base64-wpt-test
branch
from
f4eda68 to
75c6164
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Blocked on #9266 |
op_crates/web/08_text_encoding.js
Outdated
Comment on lines
133
to
134
| "The string to be encoded contains characters " + | ||
| "outside of the Latin1 range.", |
There was a problem hiding this comment.
Unrelated, but why is this a string concat?
There was a problem hiding this comment.
An attempt at formatting was made?
Collapsed them.
Co-authored-by: Luca Casonato <lucacasonato@yahoo.com>
lucacasonato
pushed a commit
that referenced
this pull request
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9001