Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(00_webidl.js): Add internal enumConverter helper #9504

Merged
merged 7 commits into from Feb 15, 2021
Merged

(00_webidl.js): Add internal enumConverter helper #9504

merged 7 commits into from Feb 15, 2021

Conversation

ghost
Copy link

@ghost ghost commented Feb 14, 2021

Part of #9498 (comment)

There are currently no generic checks or conversion to/from a WebIDL string enumeration, this PR adds an internal helper for use in implementing builtins.

cc @lucacasonato

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment

op_crates/web/00_webidl.js Outdated Show resolved Hide resolved
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@00ff0000red Thanks for bearing through all my change requests. Lets land it.

@lucacasonato lucacasonato merged commit a6beab8 into denoland:master Feb 15, 2021
kitsonk pushed a commit that referenced this pull request Feb 15, 2021
Co-authored-by: Luca Casonato <lucacasonato@yahoo.com>
@ghost ghost deleted the patch-6 branch February 16, 2021 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants