Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add throughput benchmark #961

Merged
merged 2 commits into from
Oct 11, 2018
Merged

Add throughput benchmark #961

merged 2 commits into from
Oct 11, 2018

Conversation

ry
Copy link
Member

@ry ry commented Oct 11, 2018 •
edited
Loading

Fixes #890

@ry ry requested a review from piscisaureus October 11, 2018 09:06
@ry
Copy link
Member Author

ry commented Oct 11, 2018 •
edited
Loading

@piscisaureus PTAL - seems to be working. I will squash upon approval.

piscisaureus
piscisaureus reviewed Oct 11, 2018
View reviewed changes
tools/throughput_benchmark.py
echo_server = subprocess.Popen(
[deno_exe, "--allow-net", "tests/echo_server.ts", ADDR])

time.sleep(1) # wait for deno to wake up. TODO racy.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure it is done compiling ts in 1 sec?

piscisaureus
piscisaureus approved these changes Oct 11, 2018
View reviewed changes
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I will make it work on windows some day.

@ry ry merged commit c814d5a into denoland:master Oct 11, 2018
@ry ry deleted the throughput_bench branch October 11, 2018 20:55
@ghost
Copy link

ghost commented Oct 12, 2018

you're mixing a lot of processes and other tainting factors: deno, python, head, netcat, timers. also, this test stops at 10mb as smallest echo.

when possible to do so, a better test with a full range from small to large using only deno and not starting and stopping timers over and over is needed.

this test kind of ignores everything i've talked about so far.. 10mb is not small, you never send 10mb reaponses in Rest services or ws messages

@iuioiua iuioiua mentioned this pull request May 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ry @piscisaureus