Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(op_crates): move op_crates ops to serde ops #9817

Merged
merged 1 commit into from
Mar 17, 2021
Merged

refactor(op_crates): move op_crates ops to serde ops #9817

merged 1 commit into from
Mar 17, 2021

Conversation

crowlKats
Copy link
Member

No description provided.

ry
ry reviewed Mar 17, 2021
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused. Do I have it right: functionally this is the same, it's just the serde_json::from_value is implicit?

@crowlKats
Copy link
Member Author

I'm a bit confused. Do I have it right: functionally this is the same, it's just the serde_json::from_value is implicit?

this is just using #9423, as it currently is only used for webgpu

ry
ry approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - forgot about that one!

@ry ry merged commit b3fe851 into denoland:main Mar 17, 2021
@crowlKats crowlKats deleted the op_crates_serde_ops branch March 17, 2021 21:36
@crowlKats crowlKats mentioned this pull request Mar 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crowlKats @ry