Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quickfix #9903 by moving assert into async match branches #9904

Closed
wants to merge 1 commit into from

Conversation

AaronO
Copy link
Contributor

@AaronO AaronO commented Mar 26, 2021

This is a quickfix for #9903. It moves the assert into the async branches.

However the shared queue should be dropped very soon and will also fix this issue.

@inteon
Copy link
Contributor

inteon commented Mar 26, 2021

@AaronO I think this might still cause failure, I propose to just remove the check.
This will be the case if (adaptation on original bug-report):

  • Two async Ops resolve at the exact same time (between two polls of the JsRuntime)
  • An async op is dispatched in the async callback for the first async op

@fasterthanlime
Copy link

@inteon Yup, I can confirm that the quickfix does not address the variant you outlined in #9904 (comment) (I have a local branch of a proprietary codebase I was able to tweak to test that case).

Removing the shared queue sounds good, happy to wait for that — we can live with a fork+cargo-patch for now.

@AaronO AaronO closed this Mar 26, 2021
@AaronO AaronO deleted the quickfix/9903 branch March 26, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants