Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: AuthTokens #18

Merged
merged 2 commits into from
Aug 8, 2023
Merged

fix: AuthTokens #18

merged 2 commits into from
Aug 8, 2023

Conversation

jollytoad
Copy link
Contributor

@jollytoad jollytoad commented Oct 5, 2022 •
edited
Loading

  • Swap token & host from string split
  • Swap username & password from string split
  • Base64 encode basic auth values
  • Added tests

fixes #17

@dsherret dsherret changed the title Fix AuthTokens. fix: AuthTokens Aug 8, 2023
dsherret
dsherret approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seemed quite broken. Thanks!

@dsherret dsherret merged commit 5518e03 into denoland:main Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AuthToken fails to return appropriate token
2 participants
@jollytoad @dsherret