Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add and use Rust code from the CLI #26

Merged
merged 10 commits into from
Aug 7, 2023
Merged

feat: add and use Rust code from the CLI #26

merged 10 commits into from
Aug 7, 2023

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Aug 7, 2023

This moves out the Rust cache code from the CLI to here.

@dsherret dsherret requested a review from bartlomieju August 7, 2023 21:10
@dsherret dsherret mentioned this pull request Aug 7, 2023
Merged
bartlomieju
bartlomieju approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@dsherret dsherret merged commit 5dcb098 into denoland:main Aug 7, 2023
@dsherret dsherret deleted the deno_cache_dir_crate branch August 7, 2023 23:56
dsherret added a commit to denoland/deno that referenced this pull request Aug 8, 2023
@dsherret
refactor: use deno_cache_dir crate (#20092)
05f838a 
Uses denoland/deno_cache_dir#26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @bartlomieju