feat: ability to resolve import map #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Feb 23, 2024
| @@ -672,16 +673,25 @@ impl ConfigFile { | |||
| } | |||
| } | |||
|
|
|||
| pub fn to_import_map_path(&self) -> Option<String> { | |||
There was a problem hiding this comment.
These were not very helpful because they exist directly off of json.
| .map(Some) | ||
| } else { | ||
| Ok(Some(self.specifier.join(value)?)) | ||
| } | ||
| } |
There was a problem hiding this comment.
| @@ -19,7 +19,9 @@ percent-encoding = "2.3.0" | |||
| serde = { version = "1.0.149", features = ["derive"] } | |||
| serde_json = "1.0.85" | |||
| url = { version = "2.3.1" } | |||
| import_map = { version = "0.19.0", features = ["ext"] } | |||
There was a problem hiding this comment.
Moving this down here will make it easier to use in the CLI and also provide this functionality more easily to stuff like dnt.
bartlomieju
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't have a bunch of different ways of doing this, so let's move this down here. It will also be useful in stuff like dnt.
See CLI PR here: denoland/deno#22553
Part of denoland/deno#22270