Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: derive Hash on more structs #53

Merged
merged 1 commit into from
May 29, 2024
Merged

fix: derive Hash on more structs #53

merged 1 commit into from
May 29, 2024

Conversation

dsherret
Copy link
Member

In the CLI, some code is doing serde_json::to_string to get a hash of this config. We can just make these derive Hash instead.

@dsherret dsherret requested a review from bartlomieju May 29, 2024 15:22
@dsherret dsherret merged commit 0215999 into denoland:main May 29, 2024
3 checks passed
@dsherret dsherret deleted the fix_hash_trait branch May 29, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dsherret