Clamp smi in fast calls by default (#941)

Ref denoland/deno#26480 Matches Rust's `as` cast (used by slow calls)
denoland · Oct 24, 2024 · d2945fb · d2945fb
1 parent 5e67300
commit d2945fb
Show file tree

Hide file tree

Showing 28 changed files with 352 additions and 54 deletions.
diff --git a/ops/op2/dispatch_fast.rs b/ops/op2/dispatch_fast.rs
@@ -135,6 +135,8 @@ impl FastSignature {
 
     quote!(
       use deno_core::v8::fast_api::Type as CType;
+      use deno_core::v8;
+
       deno_core::v8::fast_api::CFunction::new(
         Self::#fast_function as _,
         &deno_core::v8::fast_api::CFunctionInfo::new(
@@ -230,8 +232,16 @@ impl V8FastCallType {
     match &self {
       V8FastCallType::Void => quote!(CType::Void.scalar()),
       V8FastCallType::Bool => quote!(CType::Bool.scalar()),
-      V8FastCallType::U32 => quote!(CType::Uint32.scalar()),
-      V8FastCallType::I32 => quote!(CType::Int32.scalar()),
+      V8FastCallType::U32 => quote!(v8::fast_api::CTypeInfo::new(
+        CType::Uint32,
+        v8::fast_api::SequenceType::Scalar,
+        v8::fast_api::Flags::Clamp
+      )),
+      V8FastCallType::I32 => quote!(v8::fast_api::CTypeInfo::new(
+        CType::Int32,
+        v8::fast_api::SequenceType::Scalar,
+        v8::fast_api::Flags::Clamp
+      )),
       V8FastCallType::U64 => quote!(CType::Uint64.scalar()),
       V8FastCallType::I64 => quote!(CType::Int64.scalar()),
       V8FastCallType::F32 => quote!(CType::Float32.scalar()),

diff --git a/ops/op2/test_cases/async/async_deferred.out b/ops/op2/test_cases/async/async_deferred.out
diff --git a/ops/op2/test_cases/async/async_lazy.out b/ops/op2/test_cases/async/async_lazy.out
diff --git a/ops/op2/test_cases/sync/add.out b/ops/op2/test_cases/sync/add.out
diff --git a/ops/op2/test_cases/sync/bigint.out b/ops/op2/test_cases/sync/bigint.out
diff --git a/ops/op2/test_cases/sync/bool.out b/ops/op2/test_cases/sync/bool.out
diff --git a/ops/op2/test_cases/sync/bool_result.out b/ops/op2/test_cases/sync/bool_result.out
diff --git a/ops/op2/test_cases/sync/buffers.out b/ops/op2/test_cases/sync/buffers.out
diff --git a/ops/op2/test_cases/sync/buffers_copy.out b/ops/op2/test_cases/sync/buffers_copy.out
diff --git a/ops/op2/test_cases/sync/cfg.out b/ops/op2/test_cases/sync/cfg.out
diff --git a/ops/op2/test_cases/sync/clippy_allow.out b/ops/op2/test_cases/sync/clippy_allow.out