Allow cloning Rc<ContextState> into new contexts
#693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
reviewed
Apr 10, 2024
mmastrac
reviewed
Apr 10, 2024
Nope |
mmastrac
approved these changes
Apr 10, 2024
littledivy
added a commit
to denoland/deno
that referenced
this pull request
Apr 13, 2024
Fixes #23297 `docusaurus build` works! ``` $ deno run -A repro.js fish: Job 1, 'deno run -A ../../littledivy/fs…' terminated by signal SIGSEGV (Address boundary error) $ denod run -A repro.js error: Uncaught (in promise) Error: rejected ``` Depends on denoland/deno_core#693
bartlomieju
pushed a commit
to denoland/deno
that referenced
this pull request
Apr 15, 2024
Fixes #23297 `docusaurus build` works! ``` $ deno run -A repro.js fish: Job 1, 'deno run -A ../../littledivy/fs…' terminated by signal SIGSEGV (Address boundary error) $ denod run -A repro.js error: Uncaught (in promise) Error: rejected ``` Depends on denoland/deno_core#693
littledivy
added a commit
to littledivy/deno
that referenced
this pull request
Apr 19, 2024
Fixes denoland#23297 `docusaurus build` works! ``` $ deno run -A repro.js fish: Job 1, 'deno run -A ../../littledivy/fs…' terminated by signal SIGSEGV (Address boundary error) $ denod run -A repro.js error: Uncaught (in promise) Error: rejected ``` Depends on denoland/deno_core#693
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for denoland/deno#23305
Allowing cloning
Rc<ContextState>into new contexts.During cleanup we assert that main context does not have more than one strong count to
JsRuntimeStatebut this may not be true when there are more than one contexts that may not have been GC'ed yet. Hence, JsRuntimeState is now stored as a pointer to OpCtx as it is guarnateed to live longer than ops.