Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(html): proper tag order #630

Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix(html): proper tag order #630

merged 1 commit into from
Sep 25, 2024

Conversation

crowlKats
Copy link
Member

@crowlKats crowlKats commented Sep 19, 2024 •
edited
Loading

@marvinhagemeister
Copy link
Contributor

Not sure why the CI isn't running.

kt3k
kt3k approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with the local build that this fixed the order of readonly and optional tags:

BEFORE
Screenshot 2024-09-24 at 19 02 19

AFTER
Screenshot 2024-09-24 at 19 01 49

I think we can land this without test as this only replaces HashMap type with IndexSet drop-in replacement type (no logic is changed).

@crowlKats crowlKats merged commit f196eaa into main Sep 25, 2024
6 checks passed
@crowlKats crowlKats deleted the jsdoc-tag-order branch September 25, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crowlKats @marvinhagemeister @kt3k