Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tini to container #161

Closed
felipecrs opened this issue Aug 24, 2021 · 1 comment · Fixed by #165
Closed

Add tini to container #161

felipecrs opened this issue Aug 24, 2021 · 1 comment · Fixed by #165
Labels
enhancement New feature or request

Comments

@felipecrs
Copy link
Contributor

felipecrs commented Aug 24, 2021

While the README suggests to use docker run --init, the bullet-proof approach would be to bundling tini in the container itself, as stated in the docker best practices guides for the official images:

https://github.com/docker-library/official-images#init

Its binary is extremely tiny and should not cause any noticeable increase in the size of the docker image.

@wperron
Copy link
Contributor

wperron commented Aug 25, 2021

Very much in favor, I actually just hit the issue of not handling SIGTERM on a demo Docker container, --init is super easy to forget or simply not know about.

@wperron wperron added the enhancement New feature or request label Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants