Add tini to the images

[felipecrs]

Closes #161

[felipecrs]

References: krallin/tini-images#9

[felipecrs]

@wperron any word about the distroless and centos approach? It's the only place where we pin the tini version.

[wperron]

@wperron any word about the distroless and centos approach? It's the only place where we pin the tini version.

We should probably pin the other's version to the same version as well then, I know this is possible with apt, pretty sure it's also possible with apk for Alpine. if the versions on those package managers is lower than the latest GitHub release then let's just revert to the oldest so that they all use the same version.

Otherwise looks good to me 👍 Inspecting the images locally, this change barely adds around 1.7Mb to the images, I think that's fine given the benefits we get from it.

[felipecrs]

this change barely adds around 1.7Mb to the images, I think that's fine given the benefits we get from it.

Well, this is way more than I expected... as the size of tini binary (non-statically compiled) is 23.5KB. The static one is still less than 1MB.

[wperron]

this change barely adds around 1.7Mb to the images, I think that's fine given the benefits we get from it.

Well, this is way more than I expected... as the size of tini binary (non-statically compiled) is 23.5KB. The static one is still less than 1MB.

I'm guessing there's also some dynamic dependencies or other files being installed on the filesystem that are required for it to work. I'll dive deeper later today, but as I said, it's nothing that would prevent a merge imo

[felipecrs]

@wperron now all uses the same tini binary (not the statically compiled one), and the final size of the image was not even noticeable affected:

❯ container-diff diff daemon://deno:debian daemon://deno:debian-tini-small --type=file --type=size

-----File-----

These entries have been added to deno:debian:
FILE         SIZE
/tini        23.5K

These entries have been deleted from deno:debian: None

These entries have been changed between deno:debian and deno:debian-tini-small: None

-----Size-----

Image size difference between deno:debian and deno:debian-tini-small:
SIZE1         SIZE2
163.7M        163.7M

It turned out that the tini provided by the distribution was installing both variants of tini, which I think is unnecessary.

The advice is: https://github.com/krallin/tini#statically-linked-version

As it did not fail to start, I guess we are good to go.

What surprised me is that it worked even for the distroless. :)

[wperron]

LGTM with a minor nitpick; can we get the tini version in an arg like we do for the deno version?

[felipecrs]

@wperron isn't this already the case?

https://github.com/denoland/deno_docker/pull/165/files#diff-67288c18ec7a53187d571bc35f814046c2b87c50b5a8ac78c6d1d6a818232c66R10

[wperron]

LGTM with a minor nitpick; can we get the tini version in an arg like we do for the deno version?

Yeah sorry, nevermind me

[wperron]

LGTM, Thanks!