Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: coalesce multiple same-specifier imports correctly #137

Merged
merged 7 commits into from
Feb 6, 2023

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Feb 13, 2022

Fixes #136. Also generally makes the first occurrence (rather than the last) take priority for duplicate imports.

@dsherret dsherret self-requested a review February 6, 2023 19:37
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @nayeemrmn!

@dsherret dsherret changed the title fix: Coalesce multiple same-specifier imports correctly fix: coalesce multiple same-specifier imports correctly Feb 6, 2023
@dsherret dsherret merged commit 5f69b96 into denoland:main Feb 6, 2023
@nayeemrmn nayeemrmn deleted the coalesce-same-specifier-imports branch February 11, 2023 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static and dynamic import of the same module should be static dep
2 participants