fix: native default jsxImportSource resolution
#176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for natively resolving a default jsxImportSource specified in a config file per module.
lucacasonato
force-pushed
the
native_default_jsx_import_source
branch
from
69898ec to
15f3eaf
Compare
kitsonk
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for natively resolving a default
jsxImportSource specified in a config file per module.
The fix that this allows for upstream is that all
jsxImportSources should be resolved relative to the moduleat all times. Right now we resolve relative to the config
file in the graph, and relative to the module at runtime.
Towards denoland/deno#15559
Upstream integration: denoland/deno#15561