perf: reduce some clones and pre-allocate some collections #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Feb 6, 2023
| for root in &self.roots { | ||
| validate(root, None, types_only, false, &mut seen, &|s| { | ||
| self.try_get(s).map(|o| o.cloned()) |
bartlomieju
reviewed
Feb 7, 2023
src/graph.rs
Outdated
| @@ -769,15 +769,16 @@ impl ModuleGraph { | |||
| /// returning the "final" module. | |||
| pub fn resolve(&self, specifier: &ModuleSpecifier) -> ModuleSpecifier { | |||
| let mut redirected_specifier = specifier; | |||
| let mut seen = HashSet::new(); | |||
| let max_redirects = 6; | |||
There was a problem hiding this comment.
Does this match the number of allowed redirects in CLI file fetcher?
There was a problem hiding this comment.
That is 10, I will increase this
bartlomieju
approved these changes
Feb 7, 2023
|
The redirects here are just a module graph thing so the code couldn’t be shared. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.