Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ModuleGraph segment and walk #216

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Feb 7, 2023

@dsherret dsherret requested a review from bartlomieju February 7, 2023 19:53
impl<'a> Iterator for ModuleEntryIterator<'a> {
type Item = (&'a ModuleSpecifier, ModuleEntryRef<'a>);

fn next(&mut self) -> Option<Self::Item> {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This body of this is essentially copy and paste from the CLI, but adapted to work as an iterator.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 24e5ba9 into denoland:main Feb 7, 2023
@dsherret dsherret deleted the feat_add_segment_and_walk branch February 7, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants