Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set types specifier for jsxImportSourceTypes #462

Merged
merged 2 commits into from
Apr 30, 2024
Merged

fix: set types specifier for jsxImportSourceTypes #462

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af3f0aa
fix: set types specifier for jsxImportSourceTypes
dsherret Apr 30, 2024
b6ae1ad
add test
dsherret Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/graph.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2388,6 +2388,7 @@ pub(crate) fn parse_js_module_from_module_info(
maybe_resolver,
maybe_npm_resolver,
);
dep.maybe_deno_types_specifier = Some(specifier_text);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should rename this maybe_types_specifier? The problem here is that this was getting lost with Dependency::with_new_resolver

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see - yes, I think that makes sense.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a test for this here, do a release, then do that in a followup since it's a breaking change.

}
}
dep.imports.push(Import {
Expand Down