Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: avoid allocations in graph.resolve #515

Merged
merged 3 commits into from
Aug 24, 2024
Merged

perf: avoid allocations in graph.resolve #515

merged 3 commits into from
Aug 24, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Aug 23, 2024 •
edited
Loading

  1. Conditionally allocates the redirect HashSet.
  2. Returns a reference from graph.resolve instead of cloning.

@dsherret dsherret changed the title perf: avoid redirect allocations in graph.resolve perf: avoid allocations in graph.resolve Aug 23, 2024
@dsherret dsherret requested a review from bartlomieju August 23, 2024 23:47
@dsherret dsherret merged commit 9d02926 into denoland:main Aug 24, 2024
16 checks passed
@dsherret dsherret deleted the perf_avoid_allocations_resolve branch August 24, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @marvinhagemeister