Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update for Deno 2 #329

Merged
merged 3 commits into from
Oct 23, 2024
Merged

refactor: update for Deno 2 #329

merged 3 commits into from
Oct 23, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Oct 22, 2024

This change makes local development possible with Deno 2.

Pre-requisite for #327 and #330

@iuioiua
Copy link
Contributor Author

iuioiua commented Oct 22, 2024

PTAL @kt3k

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.76%. Comparing base (57605e7) to head (f800568).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
- Coverage   99.15%   96.76%   -2.39%     
==========================================
  Files          22       25       +3     
  Lines         475      588     +113     
  Branches       24       32       +8     
==========================================
+ Hits          471      569      +98     
- Misses          2       17      +15     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice!

@kt3k kt3k merged commit 67e94d3 into denoland:main Oct 23, 2024
8 checks passed
@iuioiua iuioiua deleted the deno-2 branch October 23, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants