-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hundreads of panics when testing broken files #1145
Comments
Thanks for reporting. I'll look into it |
@qarmin Could you break the error you got into separate ones? I ran deno_lint on your uploaded files but I only see "unexpected eof" or "unterminated regexp" so far, which I don't think are crashes. |
There is too much files to create issues one by one. First I compiled dlint with simplescreenrecorder-2023-04-10_11.12.57.mp4 |
@qarmin Thanks, I figured out what files are causing the first crash ( |
Probably my minimization tool found two crashes inside file(one inside New pack of broken files - Broken_37.zip.zip
Few files probably causes infinite loop(I killed app after 20 seconds of running) |
This commit prevents dlint from panicking when the input file doesn't contain a final newline character. Towards #1145
This commit prevents panics from happening when scope analysis fails in `prefer-const` rule. Towards #1145
Still crashes with latest branch |
When running over hundreads of broken(or even sometimes valid) Javascript/Typescript files, I got multiple crashes
Code Snippet
Example of broken files
{
/finallyimplements Cop/yrg
Example output:
Pack of broken files(973 files, many will crash with same backtrace - most is less than 1KB is size) - Broken_973.zip
Version
Denolint - c801e44
The text was updated successfully, but these errors were encountered: