Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add no-await-in-sync-fn rule #1176

Merged
merged 5 commits into from
Jul 12, 2023
Merged

feat: add no-await-in-sync-fn rule #1176

merged 5 commits into from
Jul 12, 2023

Conversation

marvinhagemeister
Copy link
Contributor

Noticed in denoland/fresh#1454 that the default v8 warning is a bit meh. This lint rule should provide a better editor experience.

bartlomieju
bartlomieju reviewed Jul 12, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be in the recommended set

bartlomieju
bartlomieju approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marvinhagemeister marvinhagemeister merged commit 950665f into main Jul 12, 2023
4 checks passed
@marvinhagemeister marvinhagemeister deleted the no-await-in-sync-fn branch July 12, 2023 18:52
@marvinhagemeister marvinhagemeister mentioned this pull request Jul 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marvinhagemeister @bartlomieju