Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update examples in valid section #1226

Merged
merged 3 commits into from
Jan 13, 2024
Merged

docs: update examples in valid section #1226

merged 3 commits into from
Jan 13, 2024

Conversation

skanehira
Copy link
Contributor

fix: #1221
ref: #1222

magurotuna
magurotuna reviewed Jan 12, 2024
View reviewed changes
Copy link
Member

@magurotuna magurotuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! Left one comment

docs/rules/no_deprecated_deno_api.md Outdated Show resolved Hide resolved
@magurotuna magurotuna mentioned this pull request Jan 12, 2024
Closed
@skanehira @magurotuna
Update docs/rules/no_deprecated_deno_api.md
e3cb114 
Co-authored-by: Yusuke Tanaka <yusuktan@maguro.dev>
@skanehira skanehira requested a review from magurotuna January 12, 2024 14:00
@magurotuna
Copy link
Member

Can you run the commands as described in the step 6 here? https://github.com/denoland/deno_lint#submitting-a-pull-request

@skanehira
Copy link
Contributor Author

Can you run the commands as described in the step 6 here? https://github.com/denoland/deno_lint#submitting-a-pull-request

@magurotuna Fixed :)

magurotuna
magurotuna approved these changes Jan 13, 2024
View reviewed changes
Copy link
Member

@magurotuna magurotuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@magurotuna magurotuna merged commit 9301481 into denoland:main Jan 13, 2024
6 checks passed
@skanehira skanehira deleted the fix-docs-deprecated-deno-api branch January 14, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magurotuna magurotuna magurotuna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hint is wrong when use deno.readAll
2 participants
@skanehira @magurotuna