Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove LinterBuilder #1296

Merged
merged 2 commits into from
Jul 23, 2024
Merged

refactor: remove LinterBuilder #1296

merged 2 commits into from
Jul 23, 2024

Conversation

dsherret
Copy link
Member

I want to add more options here and I think the builder pattern is harder to ensure everything is setup correctly.

bartlomieju
bartlomieju approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 28b0a25 into denoland:main Jul 23, 2024
6 checks passed
@dsherret dsherret deleted the refactor_remove_linter_builder branch July 23, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@magurotuna magurotuna Awaiting requested review from magurotuna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @bartlomieju