Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ability to provide a custom docs url #1297

Merged
merged 6 commits into from
Jul 24, 2024
Merged

feat: ability to provide a custom docs url #1297

merged 6 commits into from
Jul 24, 2024

Conversation

dsherret
Copy link
Member

This is so we can link to JSR docs for certain lint rules in the CLI.

bartlomieju
bartlomieju approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'm not sure about changing the code. Well probably need to revert that once we add plugins

@dsherret
Copy link
Member Author

I reverted the code change.

@dsherret dsherret merged commit 5299ecf into denoland:main Jul 24, 2024
6 checks passed
@dsherret dsherret deleted the feat_custom_docs_url branch July 24, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @bartlomieju