feat: add jsx-no-unescaped-entities rule #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Nov 29, 2024
bartlomieju
reviewed
Nov 29, 2024
| } | ||
|
|
||
| const MESSAGE: &str = "Found one or more unescaped entities in JSX text"; | ||
| const HINT: &str = "Escape the '\">} characters respectively"; |
There was a problem hiding this comment.
This is confusing - is ' character supposed to be escaped? If so it's not listed in the list below
There was a problem hiding this comment.
It's listed here
| assert_lint_err! { | ||
| JSXNoUnescapedEntities, | ||
| filename: "file:///foo.jsx", | ||
| r#"<div>'">}</div>"#: [ |
There was a problem hiding this comment.
Please exercise all possible characters here
There was a problem hiding this comment.
They're all listed
marvinhagemeister
force-pushed
the
unescaped-entities
branch
from
b019dab to
a2a2bea
Compare
bartlomieju
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule ensure that you're not accidentally passing entities like
>as text when you didn't intend to.